BriBaSA_ex crash fixes#267
Open
JaceCear wants to merge 9 commits into
Open
Conversation
freshollie
reviewed
May 17, 2026
| #ifndef GUARD_CONSTANTS_CHARACTERS_H | ||
| #define GUARD_CONSTANTS_CHARACTERS_H | ||
|
|
||
| #if 01 |
freshollie
reviewed
May 17, 2026
| NUM_CHARACTERS | ||
| } ECharacters; | ||
| #else | ||
| // TODO: Right now these have to be defined like this for BriBaSA_ex to work. |
Collaborator
There was a problem hiding this comment.
Btw since we have constants/sa2 split out from constants/sa1 I think we can remove the enum for now?
Collaborator
Author
There was a problem hiding this comment.
I mean, moving it to a different file would be unintuitive...
But overall it's definitely better to have an enum than #defines
Collaborator
There was a problem hiding this comment.
I agree enum is better, but atm we have both lol
freshollie
reviewed
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.